Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_GPS: support GPSx_GNSS_MODE for F9P #26922

Merged
merged 3 commits into from
Jun 9, 2024

Conversation

andyp1per
Copy link
Collaborator

@andyp1per andyp1per commented Apr 29, 2024

This provides limited support for the GPSx_GNSS_MODE parameter. Specifically it allows you to turn off and on the SBAS. Galileo, Beidou and Glonass constellations. All signals for these constellations are left at the defaults. GPS and QZSS are left enabled as recommended and cannot be changed.

This PR also fixes 2 bugs in the UBLOX driver:

  • Extensions are actually 30*N bytes for N extensions. Previously the buffer was sized too small meaning that extensions could be missed.
  • 1 byte configuration items only use the LSB, so the other 7 bits need to masked out when checking that a configuration item is enabled or disabled

This work kindly sponsored by LightDynamix

@andyp1per andyp1per added the WIP label Apr 29, 2024
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you'll find that lots of config combinations are not allowed. We need some way to stop this trying forever

libraries/AP_GPS/AP_GPS_UBLOX.cpp Outdated Show resolved Hide resolved
@andyp1per andyp1per force-pushed the pr-f9p-constellations branch from 47f78b0 to 5b50d69 Compare April 30, 2024 13:18
@andyp1per andyp1per removed the WIP label Apr 30, 2024
@andyp1per
Copy link
Collaborator Author

I have verified that all the allowed configurations work.

@andyp1per andyp1per requested a review from tridge April 30, 2024 13:37
@andyp1per andyp1per force-pushed the pr-f9p-constellations branch 2 times, most recently from cf4b743 to aae1764 Compare May 2, 2024 08:49
@andyp1per andyp1per force-pushed the pr-f9p-constellations branch from aae1764 to 514c8cd Compare May 21, 2024 17:05
libraries/AP_GPS/AP_GPS_UBLOX.cpp Outdated Show resolved Hide resolved
libraries/AP_GPS/AP_GPS_UBLOX.h Show resolved Hide resolved
@tridge tridge removed the DevCallEU label May 22, 2024
@andyp1per andyp1per force-pushed the pr-f9p-constellations branch from 13d200f to 0dcd852 Compare May 22, 2024 11:43
@andyp1per andyp1per requested a review from tridge May 22, 2024 12:32
@MallikarjunSE
Copy link
Contributor

Hey @andyp1per is it possible to look at F10N too?
This module doesn't support GLONASS and sometimes very randomly I get GPS still configuring.

@andyp1per
Copy link
Collaborator Author

Hi @MallikarjunSE this work was sponsored by LightDyamix and I am done at this point. There are many enhancements that could be considered - including M10 support. Happy to look at this on a commercial basis, but I would need a sample as well to get it working. Cheers Andy

@tridge
Copy link
Contributor

tridge commented May 23, 2024

@MallikarjunSE I can test the F10N you sent me

@MallikarjunSE
Copy link
Contributor

@MallikarjunSE I can test the F10N you sent me

Thanks @tridge

libraries/AP_GPS/AP_GPS_UBLOX.cpp Outdated Show resolved Hide resolved
@tridge tridge added WikiNeeded needs wiki update and removed DevCallEU labels May 29, 2024
andyp1per added 2 commits May 30, 2024 18:06
support detecting F9P hardware variant
fix bug in extension buffer management
support NEO-F9P GNSS configuration
allow multiple configuration values to be set in one go
phase F9 configuration to account for GNSS reset
@andyp1per andyp1per force-pushed the pr-f9p-constellations branch from 0dcd852 to 9051f45 Compare May 30, 2024 17:06
@andyp1per andyp1per requested a review from tridge May 30, 2024 20:08
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on F10-N and Zed-F9P

@tridge tridge merged commit 2af6358 into ArduPilot:master Jun 9, 2024
91 checks passed
@andyp1per andyp1per deleted the pr-f9p-constellations branch June 9, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement WikiNeeded needs wiki update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants